Expose WAL-G runtime settings in BackupConfig#67
Conversation
|
Hi @3loymag! Thanks for your contribution! Talking about WALG_COMPRESSION_METHOD - despite the fact that wal-g allows changing compression type, we make use of brotli as the most battle-tested in our environments one, and it gives suitable balance between speed and compression rate and should be enough for clusters up to several terabytes. And GOMAXPROCS should also be dynamically configured according to sidecar container limits, so there should be no reason to tune it manually. Can you define which limits do you run into, so we can help you to resolve them or define params that are actually required? |
Endevir
left a comment
There was a problem hiding this comment.
Need to resolve questions in #67 (comment)
Description
This PR adds optional WAL-G runtime settings under
BackupConfig.spec.walg.Previously, several WAL-G runtime parameters were only configurable through hardcoded defaults in
NewConfigWithDefaults(), for exampleWALG_COMPRESSION_METHOD,GOMAXPROCS,TOTAL_BG_UPLOADED_LIMIT,WALG_FAILOVER_STORAGES_*, andWALG_PREVENT_WAL_OVERWRITE.This makes operational tuning harder because optimal values may depend on database size, CPU limits, S3/MinIO performance, network limits, WAL generation rate, and backup/restore requirements.
With this change, users can configure these settings declaratively through a
BackupConfigmanifest, for example:Checklist: